Enhance disk driver and container status handling#1015
Merged
cgalibern merged 20 commits intoopensvc:mainfrom Apr 23, 2026
Merged
Enhance disk driver and container status handling#1015cgalibern merged 20 commits intoopensvc:mainfrom
cgalibern merged 20 commits intoopensvc:mainfrom
Conversation
mode = access => mode = bridge
The args.T type has a Parse func to convert a string to shlex-split stringslice, but lacked a String func to do the reverse operation.
Example: items[0].data.status.resources."container#0".info.id = "a1c8c719730d5698af4262058c095823400893a5a5e655189ff20ce551fc7929" items[0].data.status.resources."container#0".info.image_id = "sha256:350b164e7ae1dcddeffadd65c76226c9b6dc5553f5179153fb0e36b78f2a5e06" items[0].data.status.resources."container#0".info.pid = 9880 items[0].data.status.resources."container#0".info.name = "tty-proxy.container.0" items[0].data.status.resources."container#1".info.id = "d2e8bc2c8272ae950797ffef21e64eee654fc6b71f1cc5fb0d9debd11eaa231e" items[0].data.status.resources."container#1".info.image_id = "sha256:242b7b8f5dc73ba22b7c7599926156549ddb72c6e8fc776e5143fefbb4c0e4a6" items[0].data.status.resources."container#1".info.pid = 10330 items[0].data.status.resources."container#1".info.name = "tty-proxy.container.1"
We observed a EBUSY error on a zvol destroy just after a "drbdadm down <res>". Make sure the kernel async teardown is finished before proceeding with sub devices unprovisioners.
This patch also improves core/pool readability with a new pool.FS type replacing the AddFS() very long prototype. Also offer pool drivers a way to set default mnt_opt and mkfs_opt values.
* Put fetched config in /var/tmp/opensvc * Use a .conf.tmp suffix So the opensvc config ftdetect pattern is matched.
This syntax was supported in version 2.1.
The patch adds a vpath.ErrAccess type that embeds the vol path
and avail state so the error receiver can format custom logs
from that.
Example:
$ bin/om testnfs config show --section volume#1,app#0
[volume#1]
volatile = true
size = 1m
install = /nfs from ./cfg/{name} key script mode 750 user root group root
[app#0]
start = {name}-vol-1/nfs start
stop = {name}-vol-1/nfs stop
check = {name}-vol-1/nfs status
$ bin/om testnfs instance status -r
testnfs down
└ instances
├ dev2n2 down frozen node-frozen not-provisioned idle
└ dev2n1 down frozen node-frozen idle
└ resources
├ volume#1 ........ down testnfs-vol-1
│ info: vol/testnfs-vol-1 avail down
└ app#0 ...../.. n/a forking app.forking
info: not evaluated (vol/testnfs-vol-1 is down)
So we don't fail with ObjectNotFound when `stop = env` for example.
inspect can be nil even if GetInspect returned no error.
Ignored but logged issues: * ObjectNotExist * KeyNotExist * ObjectNotDecoder Example: $ bin/om svc1 config get --kw container#2.secrets_environment d/msg[456] idontexist/* e/* $ bin/om svc1 instance restart --rid container#2 18:00:51.694 INF svc1: container#2: ignore env from idontexist/*: object sec/idontexist does not exists 18:00:51.694 INF svc1: container#2: ignore env from e/*: object sec/e has no key matching '*'
cgalibern
reviewed
Apr 23, 2026
In the container.oci driver.
cgalibern
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request includes enhancements, bug fixes, and refactoring across multiple files. It introduces performance improvements, better error handling, modularization, and improved configuration handling.
Main Changes: